netdev - Re: [PATCH net-next] sctp: fix identification of new acks for SFR-CACC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20180425.132239.1603132652115291264.davem@davemloft.net>
Date:   Wed, 25 Apr 2018 13:22:39 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     marcelo.leitner@...il.com
Cc:     netdev@...r.kernel.org, linux-sctp@...r.kernel.org,
        lucien.xin@...il.com, vyasevich@...il.com, nhorman@...driver.com
Subject: Re: [PATCH net-next] sctp: fix identification of new acks for
 SFR-CACC

From: Marcelo Ricardo Leitner <marcelo.leitner@...il.com>
Date: Tue, 24 Apr 2018 18:17:35 -0300

> It's currently written as:
> 
> if (!tchunk->tsn_gap_acked) {   [1]
> 	tchunk->tsn_gap_acked = 1;
> 	...
> }
> 
> if (TSN_lte(tsn, sack_ctsn)) {
> 	if (!tchunk->tsn_gap_acked) {
> 		/* SFR-CACC processing */
> 		...
> 	}
> }
> 
> Which causes the SFR-CACC processing on ack reception to never process,
> as tchunk->tsn_gap_acked is always true by then. Block [1] was
> moved to that position by the commit marked below.
> 
> This patch fixes it by doing SFR-CACC processing earlier, before
> tsn_gap_acked is set to true.
> 
> Fixes: 31b02e154940 ("sctp: Failover transmitted list on transport delete")
> Signed-off-by: Marcelo Ricardo Leitner <marcelo.leitner@...il.com>
> ---
> 
> Even though this is a -stable candidate, please apply it to net-next
> to avoid conflicts with subsequent patches in my queue. Thanks.

Applied.

However, if you do want this to make it's way to -stable you'll have to get
it integrated into 'net' first.