netdev - Re: [PATCH net-next] l2tp: consistent reference counting in procfs and debufs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20180427.110655.2017347091283412542.davem@davemloft.net>
Date:   Fri, 27 Apr 2018 11:06:55 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     g.nault@...halink.fr
Cc:     netdev@...r.kernel.org, jchapman@...alix.com
Subject: Re: [PATCH net-next] l2tp: consistent reference counting in procfs
 and debufs

From: Guillaume Nault <g.nault@...halink.fr>
Date: Wed, 25 Apr 2018 19:54:14 +0200

> The 'pppol2tp' procfs and 'l2tp/tunnels' debugfs files handle reference
> counting of sessions differently than for tunnels.
> 
> For consistency, use the same mechanism for handling both sessions and
> tunnels. That is, drop the reference on the previous session just
> before looking up the next one (rather than in .show()). If necessary
> (if dump stops before *_next_session() returns NULL), drop the last
> reference in .stop().
> 
> Signed-off-by: Guillaume Nault <g.nault@...halink.fr>

Applied.

Your continued bug fixing and clenaups in this area are very much appreciated.