netdev - Re: [PATCH net-next] l2tp: consistent reference counting in procfs and debufs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180427154407.GG1440@alphalink.fr>
Date:   Fri, 27 Apr 2018 17:44:07 +0200
From:   Guillaume Nault <g.nault@...halink.fr>
To:     David Miller <davem@...emloft.net>
Cc:     netdev@...r.kernel.org, jchapman@...alix.com
Subject: Re: [PATCH net-next] l2tp: consistent reference counting in procfs
 and debufs

On Fri, Apr 27, 2018 at 11:06:55AM -0400, David Miller wrote:
> From: Guillaume Nault <g.nault@...halink.fr>
> Date: Wed, 25 Apr 2018 19:54:14 +0200
> 
> > The 'pppol2tp' procfs and 'l2tp/tunnels' debugfs files handle reference
> > counting of sessions differently than for tunnels.
> > 
> > For consistency, use the same mechanism for handling both sessions and
> > tunnels. That is, drop the reference on the previous session just
> > before looking up the next one (rather than in .show()). If necessary
> > (if dump stops before *_next_session() returns NULL), drop the last
> > reference in .stop().
> > 
> > Signed-off-by: Guillaume Nault <g.nault@...halink.fr>
> 
> Applied.
> 
> Your continued bug fixing and clenaups in this area are very much appreciated.

Nice to see that it's appreciated. Thanks!