netdev - Re: [PATCH bpf-next] bpf: remove tracepoints from bpf core

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20180429.003739.873200779196020197.davem@davemloft.net>
Date:   Sun, 29 Apr 2018 00:37:39 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     ast@...nel.org
Cc:     daniel@...earbox.net, ebiggers3@...il.com, netdev@...r.kernel.org,
        kernel-team@...com
Subject: Re: [PATCH bpf-next] bpf: remove tracepoints from bpf core

From: Alexei Starovoitov <ast@...nel.org>
Date: Sat, 28 Apr 2018 19:56:37 -0700

> tracepoints to bpf core were added as a way to provide introspection
> to bpf programs and maps, but after some time it became clear that
> this approach is inadequate, so prog_id, map_id and corresponding
> get_next_id, get_fd_by_id, get_info_by_fd, prog_query APIs were
> introduced and fully adopted by bpftool and other applications.
> The tracepoints in bpf core started to rot and causing syzbot warnings:
> WARNING: CPU: 0 PID: 3008 at kernel/trace/trace_event_perf.c:274
> Kernel panic - not syncing: panic_on_warn set ...
> perf_trace_bpf_map_keyval+0x260/0xbd0 include/trace/events/bpf.h:228
> trace_bpf_map_update_elem include/trace/events/bpf.h:274 [inline]
> map_update_elem kernel/bpf/syscall.c:597 [inline]
> SYSC_bpf kernel/bpf/syscall.c:1478 [inline]
> Hence this patch deletes tracepoints in bpf core.
> 
> Reported-by: Eric Biggers <ebiggers3@...il.com>
> Reported-by: syzbot <bot+a9dbb3c3e64b62536a4bc5ee7bbd4ca627566188@...kaller.appspotmail.com>
> Signed-off-by: Alexei Starovoitov <ast@...nel.org>

Acked-by: David S. Miller <davem@...emloft.net>