netdev - Re: [PATCH bpf-next] bpf: remove tracepoints from bpf core

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <cd98bc4e-03ad-17fd-8d73-253b2de3c1bb@iogearbox.net>
Date:   Mon, 30 Apr 2018 10:20:57 +0200
From:   Daniel Borkmann <daniel@...earbox.net>
To:     David Miller <davem@...emloft.net>, ast@...nel.org
Cc:     ebiggers3@...il.com, netdev@...r.kernel.org, kernel-team@...com
Subject: Re: [PATCH bpf-next] bpf: remove tracepoints from bpf core

On 04/29/2018 06:37 AM, David Miller wrote:
> From: Alexei Starovoitov <ast@...nel.org>
> Date: Sat, 28 Apr 2018 19:56:37 -0700
> 
>> tracepoints to bpf core were added as a way to provide introspection
>> to bpf programs and maps, but after some time it became clear that
>> this approach is inadequate, so prog_id, map_id and corresponding
>> get_next_id, get_fd_by_id, get_info_by_fd, prog_query APIs were
>> introduced and fully adopted by bpftool and other applications.
>> The tracepoints in bpf core started to rot and causing syzbot warnings:
>> WARNING: CPU: 0 PID: 3008 at kernel/trace/trace_event_perf.c:274
>> Kernel panic - not syncing: panic_on_warn set ...
>> perf_trace_bpf_map_keyval+0x260/0xbd0 include/trace/events/bpf.h:228
>> trace_bpf_map_update_elem include/trace/events/bpf.h:274 [inline]
>> map_update_elem kernel/bpf/syscall.c:597 [inline]
>> SYSC_bpf kernel/bpf/syscall.c:1478 [inline]
>> Hence this patch deletes tracepoints in bpf core.
>>
>> Reported-by: Eric Biggers <ebiggers3@...il.com>
>> Reported-by: syzbot <bot+a9dbb3c3e64b62536a4bc5ee7bbd4ca627566188@...kaller.appspotmail.com>
>> Signed-off-by: Alexei Starovoitov <ast@...nel.org>
> 
> Acked-by: David S. Miller <davem@...emloft.net>

Fully agree, applied to bpf-next, thanks!