netdev - Re: [PATCH V2 net-next 0/6] liquidio: enhanced ethtool --set-channels feature

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180430.092653.1474854564188442801.davem@davemloft.net>
Date:   Mon, 30 Apr 2018 09:26:53 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     felix.manlunas@...ium.com
Cc:     netdev@...r.kernel.org, raghu.vatsavayi@...ium.com,
        derek.chickles@...ium.com, satananda.burla@...ium.com,
        intiyaz.basha@...ium.com
Subject: Re: [PATCH V2 net-next 0/6] liquidio: enhanced ethtool
 --set-channels feature

From: Felix Manlunas <felix.manlunas@...ium.com>
Date: Fri, 27 Apr 2018 23:32:04 -0700

> From: Intiyaz Basha <intiyaz.basha@...ium.com>
> 
> For the ethtool --set-channels feature, the liquidio driver currently 
> accepts max combined value as the queue count configured during driver
> load time, where max combined count is the total count of input and output
> queues. This limitation is applicable only when SR-IOV is enabled, that 
> is, when VFs are created for PF. If SR-IOV is not enabled, the driver can
> configure max supported (64) queues. 
> 
> This series of patches are for enhancing driver to accept 
> max supported queues for ethtool --set-channels.
> 
> Changes in V2:
>   Only patch #6 was changed to fix these Sparse warnings reported by kbuild
>   test robot:
>     lio_ethtool.c:848:5: warning: symbol 'lio_23xx_reconfigure_queue_count'
>                          was not declared. Should it be static?
>     lio_ethtool.c:877:22: warning: incorrect type in assignment (different
>                           base types)
>     lio_ethtool.c:878:22: warning: incorrect type in assignment (different
>                           base types)
>     lio_ethtool.c:879:22: warning: incorrect type in assignment (different
>                           base types)

Series applied, thank you.