netdev - Re: [PATCH net-next 1/4] ipv6: Calculate hash thresholds for IPv6 nexthops

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 2 May 2018 12:58:56 -0600
From:   David Ahern <dsahern@...il.com>
To:     Ido Schimmel <idosch@...sch.org>,
        Eric Dumazet <eric.dumazet@...il.com>,
        Thomas.Winter@...iedtelesis.co.nz, davem@...emloft.net
Cc:     Ido Schimmel <idosch@...lanox.com>, netdev@...r.kernel.org,
        roopa@...ulusnetworks.com, nikolay@...ulusnetworks.com,
        pch@...bogen.com, jkbs@...hat.com, yoshfuji@...ux-ipv6.org,
        mlxsw@...lanox.com
Subject: Re: [PATCH net-next 1/4] ipv6: Calculate hash thresholds for IPv6
 nexthops

On 5/2/18 12:53 PM, Ido Schimmel wrote:
> 
> So this fixes the issue for me. To reproduce:
> 
> # ip -6 address add 2001:db8::1/64 dev dummy0
> # ip -6 address add 2001:db8::1/64 dev dummy1
> 
> This reproduces the issue because due to above commit both local routes
> are considered siblings... :/
> 
> local 2001:db8::1 proto kernel metric 0 
>         nexthop dev dummy0 weight 1 
>         nexthop dev dummy1 weight 1 pref medium
> 
> I think it's best to revert the patch and have Thomas submit a fixed
> version to net-next. I was actually surprised to see it applied to net.

ugly side effect of the way ecmp routes are managed in IPv6. I think
revert is the best option for now.

I need to look into a bug report related to v6 and route replace with
ecmp. I'll take a look at why the above is consolidated as well. Those
should not become an ecmp route.