netdev - Re: [PATCH bpf-next] xsk: fix 64-bit division

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <17967788-2811-892b-0126-1bc49a5b9929@iogearbox.net>
Date:   Wed, 9 May 2018 18:13:33 +0200
From:   Daniel Borkmann <daniel@...earbox.net>
To:     Randy Dunlap <rdunlap@...radead.org>,
        Björn Töpel <bjorn.topel@...il.com>,
        ast@...com, netdev@...r.kernel.org
Cc:     Björn Töpel <bjorn.topel@...el.com>,
        Stephen Rothwell <sfr@...b.auug.org.au>,
        magnus.karlsson@...el.com, linux-next@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH bpf-next] xsk: fix 64-bit division

On 05/07/2018 08:25 PM, Randy Dunlap wrote:
> On 05/07/2018 10:43 AM, Björn Töpel wrote:
>> From: Björn Töpel <bjorn.topel@...el.com>
>>
>> i386 builds report:
>>   net/xdp/xdp_umem.o: In function `xdp_umem_reg':
>>   xdp_umem.c:(.text+0x47e): undefined reference to `__udivdi3'
>>
>> This fix uses div_u64 instead of the GCC built-in.
>>
>> Fixes: c0c77d8fb787 ("xsk: add user memory registration support sockopt")
>> Signed-off-by: Björn Töpel <bjorn.topel@...el.com>
> 
> I don't know why the subject says xsk (instead of xdp), but anyway:
> 
> Reported-by: Randy Dunlap <rdunlap@...radead.org>
> Tested-by: Randy Dunlap <rdunlap@...radead.org>

Applied to bpf-next, thanks everyone!