netdev - Re: [PATCH bpf] nfp: bpf: allow zero-length capabilities

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c8b97f7e-4918-e29f-2b8f-02814c28bf96@iogearbox.net>
Date:   Wed, 9 May 2018 18:18:49 +0200
From:   Daniel Borkmann <daniel@...earbox.net>
To:     Jakub Kicinski <jakub.kicinski@...ronome.com>,
        alexei.starovoitov@...il.com
Cc:     oss-drivers@...ronome.com, netdev@...r.kernel.org
Subject: Re: [PATCH bpf] nfp: bpf: allow zero-length capabilities

On 05/09/2018 04:42 AM, Jakub Kicinski wrote:
> Some BPF capabilities carry no value, they simply indicate feature
> is present.  Our capability parsing loop will exit early if last
> capability is zero-length because it's looking for more than 8 bytes
> of data (8B is our TLV header length).  Allow the last capability to
> be zero-length.
> 
> This bug would lead to driver failing to probe with the following error
> if the last capability FW advertises is zero-length:
> 
>     nfp: BPF capabilities left after parsing, parsed:92 total length:100
>     nfp: invalid BPF capabilities at offset:92
> 
> Note the "parsed" and "length" values are 8 apart.
> 
> No shipping FW runs into this issue, but we can't guarantee that will
> remain the case.
> 
> Fixes: 77a844ee650c ("nfp: bpf: prepare for parsing BPF FW capabilities")
> Signed-off-by: Jakub Kicinski <jakub.kicinski@...ronome.com>
> Reviewed-by: Quentin Monnet <quentin.monnet@...ronome.com>

Applied to bpf tree, thanks!