netdev - Re: [PATCH net] net: Correct wrong skb_flow

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5ac360c4-0936-9c12-56cb-f81f08c925e6@gmail.com>
Date:   Thu, 10 May 2018 06:02:55 -0700
From:   Eric Dumazet <eric.dumazet@...il.com>
To:     gfree.wind@....163.com, davem@...emloft.net, daniel@...earbox.net,
        jakub.kicinski@...ronome.com, dsahern@...il.com,
        netdev@...r.kernel.org
Subject: Re: [PATCH net] net: Correct wrong skb_flow_limit check when enable
 RPS



On 05/10/2018 01:28 AM, gfree.wind@....163.com wrote:
> From: Gao Feng <gfree.wind@....163.com>
> 
> The skb flow limit is implemented for each CPU independently. In the
> current codes, the function skb_flow_limit gets the softnet_data by
> this_cpu_ptr. But the target cpu of enqueue_to_backlog would be not
> the current cpu when enable RPS. As the result, the skb_flow_limit checks
> the stats of current CPU, while the skb is going to append the queue of
> another CPU. It isn't the expected behavior.
> 
> Now pass the softnet_data as a param to softnet_data to make consistent.
>

Please add a correct Fixes: tag

By doing so, you will likely add a CC: tag to make sure the author of the code
will receive your email and give feed back.

Thanks !