netdev - Re:Re: [PATCH net] net: Correct wrong skb_flow

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <654af0ff.3e1.1634c90380e.Coremail.gfree.wind@vip.163.com>
Date:   Fri, 11 May 2018 08:18:30 +0800 (CST)
From:   "Gao Feng" <gfree.wind@....163.com>
To:     "Eric Dumazet" <eric.dumazet@...il.com>
Cc:     "davem@...emloft.net" <davem@...emloft.net>, daniel@...earbox.net,
        jakub.kicinski@...ronome.com, "David Ahern" <dsahern@...il.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re:Re: [PATCH net] net: Correct wrong skb_flow_limit check when
 enable RPS

At 2018-05-10 21:02:55, "Eric Dumazet" <eric.dumazet@...il.com> wrote:
>
>
>On 05/10/2018 01:28 AM, gfree.wind@....163.com wrote:
>> From: Gao Feng <gfree.wind@....163.com>
>> 
>> The skb flow limit is implemented for each CPU independently. In the
>> current codes, the function skb_flow_limit gets the softnet_data by
>> this_cpu_ptr. But the target cpu of enqueue_to_backlog would be not
>> the current cpu when enable RPS. As the result, the skb_flow_limit checks
>> the stats of current CPU, while the skb is going to append the queue of
>> another CPU. It isn't the expected behavior.
>> 
>> Now pass the softnet_data as a param to softnet_data to make consistent.
>>
>
>Please add a correct Fixes: tag

Thanks Eric.

I have one question about the "Fixes: tag".
Most of patches are bug fixes, but when need to add the "Fixes: tag", and when not ?

I'm not clear about it. Could you explain it please?

Best Regards
Feng

>
>By doing so, you will likely add a CC: tag to make sure the author of the code
>will receive your email and give feed back.
>
>Thanks !
>