netdev - i40e - Is i40e_force_link_state doing the right thing ?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <CABOGejK8bnwU0iqO5-GRO8FX6tCaMYtS+UORPrug3E7LqeWg1Q@mail.gmail.com>
Date:   Tue, 15 May 2018 13:15:25 -0700
From:   Chaitanya Lala <chaitanya.lala@...il.com>
To:     netdev@...r.kernel.org, mariusz.stachura@...el.com,
        mitch.a.williams@...el.com, andrewx.bowers@...el.com,
        jeffrey.t.kirsher@...el.com
Subject: i40e - Is i40e_force_link_state doing the right thing ?

Hi,

I am trying to bring up a Intel XL710 4x10G Intel card using the
latest mainline top-of-tree.
The problem is that "ifconfig up" and "ifconfig down" do not take
effect at the link state level.
I tracked the problem down to i40e_force_link_state() when it is
called from i40e_down().
It calls i40e_force_link_state with "is_up" == false. In-turn it
calls, i40e_aq_set_link_restart_an(hw, true, NULL).

Should the second argument of  i40e_aq_set_link_restart_an be "is_up"
vs the current "true"
i.e. i40e_aq_set_link_restart_an(hw, is_up, NULL). ? When I make this
change, the link state syncs-up with
the interface administrative state.

Is this a bug ?

Thanks,
Chaitanya