netdev - Re: i40e - Is i40e_force_link_state doing the right thing ?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKgT0Uf8BcK6hiY7Ff0_XYDMkB2T_mhxmW7oNbyHoPgW=fmG+w@mail.gmail.com>
Date:   Tue, 15 May 2018 13:31:30 -0700
From:   Alexander Duyck <alexander.duyck@...il.com>
To:     Chaitanya Lala <chaitanya.lala@...il.com>,
        intel-wired-lan <intel-wired-lan@...ts.osuosl.org>
Cc:     Netdev <netdev@...r.kernel.org>, mariusz.stachura@...el.com,
        Mitch Williams <mitch.a.williams@...el.com>,
        "Bowers, AndrewX" <andrewx.bowers@...el.com>,
        Jeff Kirsher <jeffrey.t.kirsher@...el.com>
Subject: Re: i40e - Is i40e_force_link_state doing the right thing ?

On Tue, May 15, 2018 at 1:15 PM, Chaitanya Lala
<chaitanya.lala@...il.com> wrote:
> Hi,
>
> I am trying to bring up a Intel XL710 4x10G Intel card using the
> latest mainline top-of-tree.
> The problem is that "ifconfig up" and "ifconfig down" do not take
> effect at the link state level.
> I tracked the problem down to i40e_force_link_state() when it is
> called from i40e_down().
> It calls i40e_force_link_state with "is_up" == false. In-turn it
> calls, i40e_aq_set_link_restart_an(hw, true, NULL).
>
> Should the second argument of  i40e_aq_set_link_restart_an be "is_up"
> vs the current "true"
> i.e. i40e_aq_set_link_restart_an(hw, is_up, NULL). ? When I make this
> change, the link state syncs-up with
> the interface administrative state.
>
> Is this a bug ?
>
> Thanks,
> Chaitanya

If you are calling i40e_down the assumption is you are bringing the
interface down, so as not to pass traffic. That is why the "is_up" is
set to false.

Could you provide the dmesg results for when you load the driver and
execute the "ifconfig up" and "ifconfig down" commands? That would
help us to understand what might be going on.

Thanks.

- Alex