netdev - Re: [PATCH] selftests/bpf: check return value of fopen in test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3fbcc868-c494-270d-9fc9-ca1173c3b932@iogearbox.net>
Date:   Thu, 17 May 2018 22:37:20 +0200
From:   Daniel Borkmann <borkmann@...earbox.net>
To:     Jesper Dangaard Brouer <brouer@...hat.com>, netdev@...r.kernel.org
Cc:     joe@...d.net.nz, Alexei Starovoitov <alexei.starovoitov@...il.com>
Subject: Re: [PATCH] selftests/bpf: check return value of fopen in
 test_verifier.c

On 05/17/2018 07:39 PM, Jesper Dangaard Brouer wrote:
> Commit 0a6748740368 ("selftests/bpf: Only run tests if !bpf_disabled")
> forgot to check return value of fopen.
> 
> This caused some confusion, when running test_verifier (from
> tools/testing/selftests/bpf/) on an older kernel (< v4.4) as it will
> simply seqfault.
> 
> This fix avoids the segfault and prints an error, but allow program to
> continue.  Given the sysctl was introduced in 1be7f75d1668 ("bpf:
> enable non-root eBPF programs"), we know that the running kernel
> cannot support unpriv, thus continue with unpriv_disabled = true.
> 
> Fixes: 0a6748740368 ("selftests/bpf: Only run tests if !bpf_disabled")
> Signed-off-by: Jesper Dangaard Brouer <brouer@...hat.com>

Applied to bpf, thanks Jesper!