netdev - Re: [PATCH v2 net-next 00/12] net: stmmac: Clean-up and tune-up

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 18 May 2018 10:17:25 +0100
From:   Jose Abreu <Jose.Abreu@...opsys.com>
To:     David Miller <davem@...emloft.net>, <Jose.Abreu@...opsys.com>
CC:     <f.fainelli@...il.com>, <netdev@...r.kernel.org>,
        <Joao.Pinto@...opsys.com>, <Vitor.Soares@...opsys.com>,
        <peppe.cavallaro@...com>, <alexandre.torgue@...com>
Subject: Re: [PATCH v2 net-next 00/12] net: stmmac: Clean-up and tune-up

Hi David,

On 17-05-2018 19:47, David Miller wrote:
> From: David Miller <davem@...emloft.net>
> Date: Thu, 17 May 2018 14:41:17 -0400 (EDT)
>
>> From: Jose Abreu <Jose.Abreu@...opsys.com>
>> Date: Thu, 17 May 2018 14:24:42 +0100
>>
>>> Given that the difference between better/worst is < 1%, I think
>>> we can conclude patches 3-13 don't affect the overall
>>> performance. I didn't profile the cache hits/miss though ...
>> Ok, thanks for making an effort to look into this more thoroughly.
>>
>> I'll apply this series to net-next, thank you.
> Sorry, I had to revert.
>
> It is one thing to say that you lack the hardware to physically test
> the changes on all chip types.
>
> It is yet another to not even test the build properly:
>
> drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c:494:10: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types]
>   .init = sun8i_dwmac_dma_init,
>           ^~~~~~~~~~~~~~~~~~~~
> drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c:494:10: note: (near initialization for ‘sun8i_dwmac_dma_ops.init’)
> cc1: some warnings being treated as errors

Yeah, I was missing CONFIG_COMPILE_TEST=y. Sorry about that. Will
respin.

Thanks and Best Regards,
Jose Miguel Abreu