netdev - Re: [PATCH v2 net-next 00/12] net: stmmac: Clean-up and tune-up

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20180517.144709.898265283908363051.davem@davemloft.net>
Date:   Thu, 17 May 2018 14:47:09 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     Jose.Abreu@...opsys.com
Cc:     f.fainelli@...il.com, netdev@...r.kernel.org,
        Joao.Pinto@...opsys.com, Vitor.Soares@...opsys.com,
        peppe.cavallaro@...com, alexandre.torgue@...com
Subject: Re: [PATCH v2 net-next 00/12] net: stmmac: Clean-up and tune-up

From: David Miller <davem@...emloft.net>
Date: Thu, 17 May 2018 14:41:17 -0400 (EDT)

> From: Jose Abreu <Jose.Abreu@...opsys.com>
> Date: Thu, 17 May 2018 14:24:42 +0100
> 
>> Given that the difference between better/worst is < 1%, I think
>> we can conclude patches 3-13 don't affect the overall
>> performance. I didn't profile the cache hits/miss though ...
> 
> Ok, thanks for making an effort to look into this more thoroughly.
> 
> I'll apply this series to net-next, thank you.

Sorry, I had to revert.

It is one thing to say that you lack the hardware to physically test
the changes on all chip types.

It is yet another to not even test the build properly:

drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c:494:10: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types]
  .init = sun8i_dwmac_dma_init,
          ^~~~~~~~~~~~~~~~~~~~
drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c:494:10: note: (near initialization for ‘sun8i_dwmac_dma_ops.init’)
cc1: some warnings being treated as errors