netdev - Re: [PATCH net-next] cxgb4: do L1 config when module is inserted

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20180521.122104.1660333635075713378.davem@davemloft.net>
Date:   Mon, 21 May 2018 12:21:04 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     ganeshgr@...lsio.com
Cc:     netdev@...r.kernel.org, nirranjan@...lsio.com,
        indranil@...lsio.com, venkatesh@...lsio.com, leedom@...lsio.com
Subject: Re: [PATCH net-next] cxgb4: do L1 config when module is inserted

From: Ganesh Goudar <ganeshgr@...lsio.com>
Date: Mon, 21 May 2018 14:45:43 +0530

> trigger an L1 configure operation when a transceiver module
> is inserted in order to cause current "sticky" options like
> Requested Forward Error Correction to be reapplied.
> 
> Signed-off-by: Casey Leedom <leedom@...lsio.com>
> Signed-off-by: Ganesh Goudar <ganeshgr@...lsio.com>

Applied, although:

> @@ -491,6 +491,9 @@ struct link_config {
>  
>  	unsigned char  link_ok;          /* link up? */
>  	unsigned char  link_down_rc;     /* link down reason */
> +
> +	unsigned char   new_module;	 /* ->OS Transceiver Module inserted */
> +	unsigned char   redo_l1cfg;	 /* ->CC redo current "sticky" L1 CFG */
>  };

The various booleans in link_config should be converted to use type 'bool'
and true/false values.