netdev - Re: [PATCH net-next] cxgb4: do L1 config when module is inserted

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20180521.122330.1373279676577548.davem@davemloft.net>
Date:   Mon, 21 May 2018 12:23:30 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     ganeshgr@...lsio.com
Cc:     netdev@...r.kernel.org, nirranjan@...lsio.com,
        indranil@...lsio.com, venkatesh@...lsio.com, leedom@...lsio.com
Subject: Re: [PATCH net-next] cxgb4: do L1 config when module is inserted

From: David Miller <davem@...emloft.net>
Date: Mon, 21 May 2018 12:21:04 -0400 (EDT)

> From: Ganesh Goudar <ganeshgr@...lsio.com>
> Date: Mon, 21 May 2018 14:45:43 +0530
> 
>> trigger an L1 configure operation when a transceiver module
>> is inserted in order to cause current "sticky" options like
>> Requested Forward Error Correction to be reapplied.
>> 
>> Signed-off-by: Casey Leedom <leedom@...lsio.com>
>> Signed-off-by: Ganesh Goudar <ganeshgr@...lsio.com>
> 
> Applied, although:

Actually I had to revert, this doesn't even compile:

drivers/scsi/csiostor/csio_hw.c: In function ‘fwcaps16_to_caps32’:
drivers/scsi/csiostor/csio_hw.c:1490:17: error: ‘FW_PORT_CAP_MDIX’ undeclared (first use in this function); did you mean ‘FW_PORT_CAP_MDI_S’?
    if (caps16 & FW_PORT_CAP_##__cap) \
                 ^