netdev - Re: [net-next 1/6] net/dcb: Add dcbnl buffer attribute

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <130570f4-25ca-9214-79fa-88ef9b208e32@mellanox.com>
Date:   Thu, 24 May 2018 09:11:43 -0500
From:   Huy Nguyen <huyn@...lanox.com>
To:     Jakub Kicinski <jakub.kicinski@...ronome.com>,
        Saeed Mahameed <saeedm@...lanox.com>
Cc:     "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org
Subject: Re: [net-next 1/6] net/dcb: Add dcbnl buffer attribute



On 5/23/2018 3:19 PM, Jakub Kicinski wrote:
> On Mon, 21 May 2018 14:04:57 -0700, Saeed Mahameed wrote:
>> diff --git a/include/uapi/linux/dcbnl.h b/include/uapi/linux/dcbnl.h
>> index 2c0c6453c3f4..1ddc0a44c172 100644
>> --- a/include/uapi/linux/dcbnl.h
>> +++ b/include/uapi/linux/dcbnl.h
>> @@ -163,6 +163,15 @@ struct ieee_pfc {
>>   	__u64	indications[IEEE_8021QAZ_MAX_TCS];
>>   };
>>   
>> +#define IEEE_8021Q_MAX_PRIORITIES 8
>> +#define DCBX_MAX_BUFFERS  8
>> +struct dcbnl_buffer {
>> +	/* priority to buffer mapping */
>> +	__u8    prio2buffer[IEEE_8021Q_MAX_PRIORITIES];
>> +	/* buffer size in Bytes */
>> +	__u32   buffer_size[DCBX_MAX_BUFFERS];
> Could you use IEEE_8021Q_MAX_PRIORITIES to size this array?  The DCBX in
> the define name sort of implies this is coming from the standard which
> it isn't.
>
I agree with your standard comment. But since priority is mapped to 
buffer, I think it is okay to reuse
#define. Let's not have a duplicate #define with the same meaning.