netdev - Re: [PATCH rdma-next v1 11/13] IB/mlx5: Add flow counters binding support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180528172752.GD17505@ziepe.ca>
Date:   Mon, 28 May 2018 11:27:52 -0600
From:   Jason Gunthorpe <jgg@...pe.ca>
To:     Leon Romanovsky <leon@...nel.org>
Cc:     Doug Ledford <dledford@...hat.com>,
        Leon Romanovsky <leonro@...lanox.com>,
        RDMA mailing list <linux-rdma@...r.kernel.org>,
        Boris Pismenny <borisp@...lanox.com>,
        Matan Barak <matanb@...lanox.com>,
        Raed Salem <raeds@...lanox.com>,
        Yishai Hadas <yishaih@...lanox.com>,
        Saeed Mahameed <saeedm@...lanox.com>,
        linux-netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH rdma-next v1 11/13] IB/mlx5: Add flow counters binding
 support

On Sun, May 27, 2018 at 01:23:44PM +0300, Leon Romanovsky wrote:

> +	if (!mcounters->hw_cntrs_hndl) {
> +		mcounters->hw_cntrs_hndl =
> +			(void *)mlx5_fc_create(to_mdev(ibcounters->device)->mdev,
> +					       false);

No unnecessary casts

> +struct mlx5_ib_flow_counters_data {
> +	__aligned_u64   counters_data;

I think this is supposed to use RDMA_UAPI_PTR() these days.

Jason