netdev - Re: [PATCH mlx5-next v1 02/13] net/mlx5: Export flow counter related API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180528091637.GJ3085@mtr-leonro.mtl.com>
Date:   Mon, 28 May 2018 12:16:37 +0300
From:   Leon Romanovsky <leonro@...lanox.com>
To:     Or Gerlitz <gerlitz.or@...il.com>
Cc:     Raed Salem <raeds@...lanox.com>,
        RDMA mailing list <linux-rdma@...r.kernel.org>,
        Yishai Hadas <yishaih@...lanox.com>,
        Saeed Mahameed <saeedm@...lanox.com>,
        linux-netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH mlx5-next v1 02/13] net/mlx5: Export flow counter related
 API

On Mon, May 28, 2018 at 11:34:18AM +0300, Or Gerlitz wrote:
> On Sun, May 27, 2018 at 1:23 PM, Leon Romanovsky <leon@...nel.org> wrote:
> > From: Raed Salem <raeds@...lanox.com>
> >
> > Exports counters API to be used in both IB and EN.
> >
> > Reviewed-by: Yishai Hadas <yishaih@...lanox.com>
> > Signed-off-by: Raed Salem <raeds@...lanox.com>
> > Signed-off-by: Leon Romanovsky <leonro@...lanox.com>
> > ---
> >  drivers/net/ethernet/mellanox/mlx5/core/fs_core.h  | 23 ----------------------
> >  .../net/ethernet/mellanox/mlx5/core/fs_counters.c  |  3 +++
> >  include/linux/mlx5/fs.h                            | 22 +++++++++++++++++++++
> >  3 files changed, 25 insertions(+), 23 deletions(-)
> >
> > diff --git a/drivers/net/ethernet/mellanox/mlx5/core/fs_core.h b/drivers/net/ethernet/mellanox/mlx5/core/fs_core.h
> > index b6da322a8016..40992aed1791 100644
> > --- a/drivers/net/ethernet/mellanox/mlx5/core/fs_core.h
> > +++ b/drivers/net/ethernet/mellanox/mlx5/core/fs_core.h
> > @@ -131,29 +131,6 @@ struct mlx5_flow_table {
> >         struct rhltable                 fgs_hash;
> >  };
> >
> > -struct mlx5_fc_cache {
> > -       u64 packets;
> > -       u64 bytes;
> > -       u64 lastuse;
> > -};
> > -
> > -struct mlx5_fc {
> > -       struct rb_node node;
> > -       struct list_head list;
> > -
> > -       /* last{packets,bytes} members are used when calculating the delta since
> > -        * last reading
> > -        */
> > -       u64 lastpackets;
> > -       u64 lastbytes;
> > -
> > -       u32 id;
> > -       bool deleted;
> > -       bool aging;
> > -
> > -       struct mlx5_fc_cache cache ____cacheline_aligned_in_smp;
> > -};
> > -
>
> are you using the caching services @ the IB driver? please point me to
> the patch that does so

IB doesn't use cache, but uses "struct mlx5_fc", which needs
mlx5_fc_cache struct for compilation.

For example in this patch [1], Raed uses "struct mlx5_fc".

[1] https://patchwork.ozlabs.org/patch/921076/

Thanks