netdev - Re: [PATCH net-next v2 1/7] net: bridge: Extract boilerplate around switchdev_port_obj

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <wihk1rngarv.fsf@dev-r-vrt-156.mtr.labs.mlnx>
Date:   Mon, 28 May 2018 16:39:00 +0300
From:   Petr Machata <petrm@...lanox.com>
To:     <netdev@...r.kernel.org>
Cc:     <devel@...verdev.osuosl.org>, <bridge@...ts.linux-foundation.org>,
        <jiri@...lanox.com>, <idosch@...lanox.com>, <davem@...emloft.net>,
        <razvan.stefanescu@....com>, <gregkh@...uxfoundation.org>,
        <stephen@...workplumber.org>, <andrew@...n.ch>,
        <vivien.didelot@...oirfairelinux.com>, <f.fainelli@...il.com>,
        <nikolay@...ulusnetworks.com>
Subject: Re: [PATCH net-next v2 1/7] net: bridge: Extract boilerplate around switchdev_port_obj_*()

Petr Machata <petrm@...lanox.com> writes:

> diff --git a/net/bridge/br_private.h b/net/bridge/br_private.h
> index 11520ed..33bd914 100644
> --- a/net/bridge/br_private.h
> +++ b/net/bridge/br_private.h
> @@ -1178,6 +1178,9 @@ static inline void br_switchdev_frame_unmark(struct sk_buff *skb)
>  }
>  #endif /* CONFIG_NET_SWITCHDEV */
>  
> +int br_switchdev_port_vlan_add(struct net_device *dev, u16 vid, u16 flags);
> +int br_switchdev_port_vlan_del(struct net_device *dev, u16 vid);
> +

Nope, this actually does need to be in the ifdef block. The whole
br_switchdev.c is built conditionally.

I'll send v3.

Petr