netdev - Re: [PATCH bpf-next 03/11] bpf: fixup error message from gpl helpers on license mismatch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180529191628.3f6aa7dd@redhat.com>
Date:   Tue, 29 May 2018 19:16:28 +0200
From:   Jesper Dangaard Brouer <brouer@...hat.com>
To:     Daniel Borkmann <daniel@...earbox.net>
Cc:     brouer@...hat.com, netdev@...r.kernel.org
Subject: Re: [PATCH bpf-next 03/11] bpf: fixup error message from gpl
 helpers on license mismatch

On Mon, 28 May 2018 02:43:36 +0200
Daniel Borkmann <daniel@...earbox.net> wrote:

> Stating 'proprietary program' in the error is just silly since it
> can also be a different open source license than that which is just
> not compatible.
> 
> Reference: https://twitter.com/majek04/status/998531268039102465
> Signed-off-by: Daniel Borkmann <daniel@...earbox.net>
> Acked-by: Alexei Starovoitov <ast@...nel.org>

Acked-by: Jesper Dangaard Brouer <brouer@...hat.com>

Thank you for cleaning up this confusion :-)

> ---
>  kernel/bpf/verifier.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/bpf/verifier.c b/kernel/bpf/verifier.c
> index 1fd9667b..4f4786e 100644
> --- a/kernel/bpf/verifier.c
> +++ b/kernel/bpf/verifier.c
> @@ -2462,7 +2462,7 @@ static int check_helper_call(struct bpf_verifier_env *env, int func_id, int insn
>  
>  	/* eBPF programs must be GPL compatible to use GPL-ed functions */
>  	if (!env->prog->gpl_compatible && fn->gpl_only) {
> -		verbose(env, "cannot call GPL only function from proprietary program\n");
> +		verbose(env, "cannot call GPL-restricted function from non-GPL compatible program\n");
>  		return -EINVAL;
>  	}
>  



-- 
Best regards,
  Jesper Dangaard Brouer
  MSc.CS, Principal Kernel Engineer at Red Hat
  LinkedIn: http://www.linkedin.com/in/brouer