netdev - Re: [PATCH net-next] net: remove bypassed check in sch_direct

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <00399207-8196-1766-330d-624f2ed35c89@cogentembedded.com>
Date:   Tue, 29 May 2018 11:58:01 +0300
From:   Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:     Song Liu <songliubraving@...com>, netdev@...r.kernel.org
Cc:     kernel-team@...com, John Fastabend <john.fastabend@...il.com>,
        Alexei Starovoitov <ast@...nel.org>,
        "David S . Miller" <davem@...emloft.net>
Subject: Re: [PATCH net-next] net: remove bypassed check in sch_direct_xmit()

Hello!

On 5/29/2018 12:36 AM, Song Liu wrote:

> Check sch_direct_xmit() at the end of sch_direct_xmit() will be bypassed.

    "Checking netif_xmit_frozen_or_stopped()", perhaps? Else it doesn't make 
much sense...

> This is because "ret" from sch_direct_xmit() will be either NETDEV_TX_OK
> or NETDEV_TX_BUSY, and only ret == NETDEV_TX_OK == 0 will reach the
> condition:
> 
>      if (ret && netif_xmit_frozen_or_stopped(txq))
>          return false;
> 
> This patch cleans up the code by removing  the whole condition.
> 
> For more discussion about this, please refer to
>     https://marc.info/?t=152727195700008
> 
> Signed-off-by: Song Liu <songliubraving@...com>
> Cc: John Fastabend <john.fastabend@...il.com>
> Cc: Alexei Starovoitov <ast@...nel.org>
> Cc: David S. Miller <davem@...emloft.net>
[...]

MBR, Sergei