netdev - Re: [PATCH mlx5-next 2/2] net/mlx5: Add FPGA QP error event

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <eeebc0dd8061b0abad35e03019fc672e9f325494.camel@mellanox.com>
Date:   Wed, 30 May 2018 17:28:06 +0000
From:   Saeed Mahameed <saeedm@...lanox.com>
To:     "andrew@...n.ch" <andrew@...n.ch>
CC:     Jason Gunthorpe <jgg@...lanox.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Ilan Tayari <ilant@...lanox.com>,
        "linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>,
        Leon Romanovsky <leonro@...lanox.com>,
        Adi Nissim <adin@...lanox.com>
Subject: Re: [PATCH mlx5-next 2/2] net/mlx5: Add FPGA QP error event

On Wed, 2018-05-30 at 18:21 +0200, Andrew Lunn wrote:
> On Wed, May 30, 2018 at 03:14:20PM +0000, Saeed Mahameed wrote:
> > On Wed, 2018-05-30 at 03:07 +0200, Andrew Lunn wrote:
> > > On Tue, May 29, 2018 at 05:19:54PM -0700, Saeed Mahameed wrote:
> > > > From: Ilan Tayari <ilant@...lanox.com>
> > > > 
> > > > The FPGA QP event fires whenever a QP on the FPGA trasitions
> > > > to the error state.
> > > 
> > > FPGA i know, field programmable gate array. Could you offer some
> > > clue
> > > as to what QP means?
> > > 
> > 
> > Hi Andre, QP "Queue Pair" is well known rdma concept, and widely
> > used
> > in mlx drivers, it is used as in the driver as a ring buffer to
> > communicate with the FPGA device.
> 
> O.K. Thanks.
> 
> It is hard to get the right balance between assuming people know
> everything, and know nothing. But you can help teach people these
> terms i commit messages:
> 
>       The FPGA queue pair event fires whenever a QP on the FPGA
>       transitions to the error state.
> 

Sure will fix the commit message in V2,

Thanks a lot for the feedback.

>    Andrew