[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <b836a69b6b9ee7059ff2fbbacbebc67e2ef4e8c1.camel@mellanox.com>
Date: Wed, 30 May 2018 17:31:37 +0000
From: Saeed Mahameed <saeedm@...lanox.com>
To: "andrew@...n.ch" <andrew@...n.ch>
CC: Jason Gunthorpe <jgg@...lanox.com>,
"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
Ilan Tayari <ilant@...lanox.com>,
"linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>,
Leon Romanovsky <leonro@...lanox.com>,
Adi Nissim <adin@...lanox.com>
Subject: Re: [PATCH mlx5-next 1/2] net/mlx5: Add temperature warning event to
log
On Wed, 2018-05-30 at 18:17 +0200, Andrew Lunn wrote:
> > Hi Andrew, yes the temperature is available by other means, this
> > patch
> > is needed for alert information reasons in order to know which
> > internal
> > sensors triggered the alarm.
> > We are working in parallel to expose temperature sensor to hwmon,
> > but
> > this is still WIP.
> >
> >
> > Is it ok to have both ?
>
> Hi Saeed
>
> Ideally no. hwmon has mechanisms for setting alarm thresholds, and
> indicating the thresholds have been exceeded. There are also ways to
> tie this to thermal zones, so the system can react on overheating,
> slow down the CPU, drop voltages, ramp up fans, etc. hwmon should be
> your primary interface, not dmesg.
>
Yes we are working on this, but it is not something that can happen
soon since we need to define the correct Firmware APIs which are still
WIP.
> But if you are stuck doing things in the wrong order, i guess it is
> O.K. I don't think dmesg is a Binary API, so you can remove it later.
>
Yes this is the plan, once the hwmon is supported we will remove the
extra dmesg warnings.
> Andrew
Powered by blists - more mailing lists