netdev - Re: [PATCH net-next] tcp: minor optimization around tcp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180531.132344.339904863786377155.davem@davemloft.net>
Date:   Thu, 31 May 2018 13:23:44 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     laoar.shao@...il.com
Cc:     edumazet@...gle.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next] tcp: minor optimization around tcp_hdr()
 usage in receive path

From: Yafang Shao <laoar.shao@...il.com>
Date: Tue, 29 May 2018 23:27:31 +0800

> This is additional to the
> commit ea1627c20c34 ("tcp: minor optimizations around tcp_hdr() usage").
> At this point, skb->data is same with tcp_hdr() as tcp header has not
> been pulled yet. So use the less expensive one to get the tcp header.
> 
> Remove the third parameter of tcp_rcv_established() and put it into
> the function body.
> 
> Furthermore, the local variables are listed as a reverse christmas tree :)
> 
> Cc: Eric Dumazet <edumazet@...gle.com>
> Signed-off-by: Yafang Shao <laoar.shao@...il.com>

Applied, thanks.