netdev - Re: [PATCH v2 net-next] net: remove bypassed check in sch_direct

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180531.132646.1424213601917141668.davem@davemloft.net>
Date:   Thu, 31 May 2018 13:26:46 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     songliubraving@...com
Cc:     netdev@...r.kernel.org, sergei.shtylyov@...entembedded.com,
        kernel-team@...com, john.fastabend@...il.com, ast@...nel.org
Subject: Re: [PATCH v2 net-next] net: remove bypassed check in
 sch_direct_xmit()

From: Song Liu <songliubraving@...com>
Date: Tue, 29 May 2018 10:03:21 -0700

> Checking netif_xmit_frozen_or_stopped() at the end of sch_direct_xmit()
> is being bypassed. This is because "ret" from sch_direct_xmit() will be
> either NETDEV_TX_OK or NETDEV_TX_BUSY, and only ret == NETDEV_TX_OK == 0
> will reach the condition:
> 
>     if (ret && netif_xmit_frozen_or_stopped(txq))
>         return false;
> 
> This patch cleans up the code by removing the whole condition.
> 
> For more discussion about this, please refer to
>    https://marc.info/?t=152727195700008
> 
> Signed-off-by: Song Liu <songliubraving@...com>

Applied, thanks.