netdev - Re: [PATCH 2/2 net-next] net_failover: fix error code in net_failover

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b11cf2ca-e230-057c-77c2-4d02efb672b6@intel.com>
Date:   Thu, 31 May 2018 10:26:41 -0700
From:   "Samudrala, Sridhar" <sridhar.samudrala@...el.com>
To:     Dan Carpenter <dan.carpenter@...cle.com>,
        "David S. Miller" <davem@...emloft.net>
Cc:     netdev@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH 2/2 net-next] net_failover: fix error code in
 net_failover_create()



On 5/31/2018 5:04 AM, Dan Carpenter wrote:
> We forgot to set the error code on this path.  This function is supposed
> to return error pointers, so with this bug it accidentally returns NULL
> and the caller doesn't check for that.
>
> Fixes: cfc80d9a1163 ("net: Introduce net_failover driver")
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>

Acked-by: Sridhar Samudrala <sridhar.samudrala@...el.com>

>
> diff --git a/drivers/net/net_failover.c b/drivers/net/net_failover.c
> index ef50158e90a9..881f3fa13e6b 100644
> --- a/drivers/net/net_failover.c
> +++ b/drivers/net/net_failover.c
> @@ -761,8 +761,10 @@ struct failover *net_failover_create(struct net_device *standby_dev)
>   	netif_carrier_off(failover_dev);
>   
>   	failover = failover_register(failover_dev, &net_failover_ops);
> -	if (IS_ERR(failover))
> +	if (IS_ERR(failover)) {
> +		err = PTR_ERR(failover);
>   		goto err_failover_register;
> +	}
>   
>   	return failover;
>