netdev - Re: [PATCH net] cls_flower: Fix incorrect idr release when failing to modify rule

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180531.151946.1140186578689899607.davem@davemloft.net>
Date:   Thu, 31 May 2018 15:19:46 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     paulb@...lanox.com
Cc:     jiri@...lanox.com, xiyou.wangcong@...il.com, jhs@...atatu.com,
        netdev@...r.kernel.org, kliteyn@...lanox.com, roid@...lanox.com,
        shahark@...lanox.com, markb@...lanox.com, ogerlitz@...lanox.com
Subject: Re: [PATCH net] cls_flower: Fix incorrect idr release when failing
 to modify rule

From: Paul Blakey <paulb@...lanox.com>
Date: Wed, 30 May 2018 11:29:15 +0300

> When we fail to modify a rule, we incorrectly release the idr handle
> of the unmodified old rule.
> 
> Fix that by checking if we need to release it.
> 
> Fixes: fe2502e49b58 ("net_sched: remove cls_flower idr on failure")
> Reported-by: Vlad Buslov <vladbu@...lanox.com>
> Reviewed-by: Roi Dayan <roid@...lanox.com>
> Acked-by: Jiri Pirko <jiri@...lanox.com>
> Signed-off-by: Paul Blakey <paulb@...lanox.com>

Applied and queued up for -stable.