netdev - Re: [PATCH net-next] netfilter: nf_tables: check msg_type before nft_trans

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180531190731.rrwayqgnnnd2fasn@breakpoint.cc>
Date:   Thu, 31 May 2018 21:07:31 +0200
From:   Florian Westphal <fw@...len.de>
To:     Alexey Kodanev <alexey.kodanev@...cle.com>
Cc:     netfilter-devel@...r.kernel.org,
        Pablo Neira Ayuso <pablo@...filter.org>,
        Jozsef Kadlecsik <kadlec@...ckhole.kfki.hu>,
        Florian Westphal <fw@...len.de>, coreteam@...filter.org,
        netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next] netfilter: nf_tables: check msg_type before
 nft_trans_set(trans)

Alexey Kodanev <alexey.kodanev@...cle.com> wrote:
> The patch moves the "trans->msg_type == NFT_MSG_NEWSET" check before
> using nft_trans_set(trans). Otherwise we can get out of bounds read.

Indeed, thanks for fixining this.

Acked-by: Florian Westphal <fw@...len.de>