netdev - Re: [PATCH net-next] netfilter: nf_tables: check msg_type before nft_trans

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180601081411.sk4py3rkduckmiyg@salvia>
Date:   Fri, 1 Jun 2018 10:14:11 +0200
From:   Pablo Neira Ayuso <pablo@...filter.org>
To:     Florian Westphal <fw@...len.de>
Cc:     Alexey Kodanev <alexey.kodanev@...cle.com>,
        netfilter-devel@...r.kernel.org,
        Jozsef Kadlecsik <kadlec@...ckhole.kfki.hu>,
        coreteam@...filter.org, netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next] netfilter: nf_tables: check msg_type before
 nft_trans_set(trans)

On Thu, May 31, 2018 at 09:07:31PM +0200, Florian Westphal wrote:
> Alexey Kodanev <alexey.kodanev@...cle.com> wrote:
> > The patch moves the "trans->msg_type == NFT_MSG_NEWSET" check before
> > using nft_trans_set(trans). Otherwise we can get out of bounds read.
> 
> Indeed, thanks for fixining this.
> 
> Acked-by: Florian Westphal <fw@...len.de>

Also applied to nf.git, thanks!