netdev - Re: [PATCH net-next] rtnetlink: validate attributes in do

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180605.124638.2018749744124606921.davem@davemloft.net>
Date:   Tue, 05 Jun 2018 12:46:38 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     edumazet@...gle.com
Cc:     netdev@...r.kernel.org, eric.dumazet@...il.com, dvyukov@...gle.com
Subject: Re: [PATCH net-next] rtnetlink: validate attributes in do_setlink()

From: Eric Dumazet <edumazet@...gle.com>
Date: Tue,  5 Jun 2018 09:25:19 -0700

> It seems that rtnl_group_changelink() can call do_setlink
> while a prior call to validate_linkmsg(dev = NULL, ...) could
> not validate IFLA_ADDRESS / IFLA_BROADCAST
> 
> Make sure do_setlink() calls validate_linkmsg() instead
> of letting its callers having this responsibility.
> 
> With help from Dmitry Vyukov, thanks a lot !
 ...
> Fixes: e7ed828f10bd ("netlink: support setting devgroup parameters")
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Reported-by: syzbot <syzkaller@...glegroups.com>

Applied and queued up for -stable.