netdev - Re: [PATCH] r8169: Reinstate ALDPS and ASPM support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ff5da1dc-09b4-90c3-6d8b-ef7dab5dc876@gmail.com>
Date:   Tue, 5 Jun 2018 09:47:22 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     David Miller <davem@...emloft.net>, andrew@...n.ch
Cc:     kai.heng.feng@...onical.com, hayeswang@...ltek.com,
        hkallweit1@...il.com, romieu@...zoreil.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, ryankao@...ltek.com, jiri@...nulli.us
Subject: Re: [PATCH] r8169: Reinstate ALDPS and ASPM support

On 06/05/2018 07:15 AM, David Miller wrote:
> From: Andrew Lunn <andrew@...n.ch>
> Date: Tue, 5 Jun 2018 16:11:14 +0200
> 
>> No module parameter please. Just turn it on by default. Assuming
>> testing shows works.
> 
> Agreed.

devlink would be a good candidate to add such configuration attributes,
since you would be operating on the PCI function itself, thus allowing
this to be on a per-device instance basis as opposed to global, which is
what a module parameter is.
-- 
Florian