netdev - Re: [PATCH nf-next] netfilter: nft_reject_bridge: remove unnecessary ttl set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMArcTXpkK7sPOUSynNMWPN0-d7d7gzFFsZzdOOAeu9_UQDS4w@mail.gmail.com>
Date:   Tue, 12 Jun 2018 01:54:05 +0900
From:   Taehee Yoo <ap420073@...il.com>
To:     davem@...emloft.net,
        Steffen Klassert <steffen.klassert@...unet.com>
Cc:     netdev@...r.kernel.org, Taehee Yoo <ap420073@...il.com>
Subject: Re: [PATCH nf-next] netfilter: nft_reject_bridge: remove unnecessary
 ttl set

2018-06-12 1:35 GMT+09:00 Taehee Yoo <ap420073@...il.com>:
> In the nft_reject_br_send_v4_tcp_reset(), a ttl is set by
> the nf_reject_ip_tcphdr_put(). so, below code is unnecessary.
>
> Signed-off-by: Taehee Yoo <ap420073@...il.com>
> ---
>  net/bridge/netfilter/nft_reject_bridge.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/net/bridge/netfilter/nft_reject_bridge.c b/net/bridge/netfilter/nft_reject_bridge.c
> index eaf05de..e0b082c 100644
> --- a/net/bridge/netfilter/nft_reject_bridge.c
> +++ b/net/bridge/netfilter/nft_reject_bridge.c
> @@ -89,8 +89,7 @@ static void nft_reject_br_send_v4_tcp_reset(struct net *net,
>         niph = nf_reject_iphdr_put(nskb, oldskb, IPPROTO_TCP,
>                                    net->ipv4.sysctl_ip_default_ttl);
>         nf_reject_ip_tcphdr_put(nskb, oldskb, oth);
> -       niph->ttl       = net->ipv4.sysctl_ip_default_ttl;
> -       niph->tot_len   = htons(nskb->len);
> +       niph->tot_len = htons(nskb->len);
>         ip_send_check(niph);
>
>         nft_reject_br_push_etherhdr(oldskb, nskb);
> --
> 2.9.3
>

I'm so sorry, I sent this to you by mistake.
Please ignore this.

Thanks