netdev - Re: WARNING: CPU: 3 PID: 0 at net/sched/sch_hfsc.c:1388 hfsc_dequeue+0x319/0x350 [sch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAM_iQpVEZFL==0BuQh26Wh-TEJ-hmz7NwGry2g7EZiK-FCjKAQ@mail.gmail.com>
Date:   Wed, 20 Jun 2018 16:00:44 -0700
From:   Cong Wang <xiyou.wangcong@...il.com>
To:     Marco Berizzi <pupilla@...ero.it>
Cc:     Linux Kernel Network Developers <netdev@...r.kernel.org>
Subject: Re: WARNING: CPU: 3 PID: 0 at net/sched/sch_hfsc.c:1388
 hfsc_dequeue+0x319/0x350 [sch_hfsc]

On Wed, Jun 20, 2018 at 12:00 AM, Marco Berizzi <pupilla@...ero.it> wrote:
>> Il 19 giugno 2018 alle 13.42 Marco Berizzi <pupilla@...ero.it> ha scritto:
>>
>> > Il 18 giugno 2018 alle 21.28 Cong Wang <xiyou.wangcong@...il.com> ha scritto:
>> > Can you test the attached patch?
>> >
>> > It almost certainly fixes the warning, but I am not sure if
>> > it papers out any other real problem. Please make sure
>> > hfsc still works as expected. :)
>>
>> Hi Cong,
>>
>> Thanks a lot for the patch. I'm building 4.17.2 + your patch.
>> Within 24 hours I will update you.
>
> Hi Cong,
>
> I have applied your patch to 4.17.2
> From my point of view hfsc is working as expected.
> However my setup is pretty simple:
>
> tc class add dev eth2 parent 1:2 classid 1:16 hfsc ls rate 3000kbit ul rate 20000kbit
>
> I can see hfsc is shaping my traffic to 20MBit/s.
> The error message has not popped up :-)
> I will drop you a message withing 48 hours for confirmation.

Please also test HFSC_RSC ("rt") if possible.


> Will this patch merged in a future kernel release?
>

If you can confirm nothing breaks, I will send it out formally.

Thanks for testing!