netdev - Re: [PATCH net] net: fib_rules: add protocol check in rule

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e95cbd6c-bbf4-edee-50d8-ff48aa15e044@gmail.com>
Date:   Thu, 28 Jun 2018 09:26:39 -0600
From:   David Ahern <dsahern@...il.com>
To:     Roopa Prabhu <roopa@...ulusnetworks.com>, davem@...emloft.net
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH net] net: fib_rules: add protocol check in rule_find

On 6/27/18 7:27 PM, Roopa Prabhu wrote:
> From: Roopa Prabhu <roopa@...ulusnetworks.com>
> 
> After commit f9d4b0c1e969 ("fib_rules: move common handling of newrule
> delrule msgs into fib_nl2rule"), rule_find is strict about checking
> for an existing rule. rule_find must check against all
> user given attributes, else it may match against a subset
> of attributes and return an existing rule.
> 
> In the below case, without support for protocol match, rule_find
> will match only against 'table main' and return an existing rule.
> 
> $ip -4 rule add table main protocol boot
> RTNETLINK answers: File exists
> 
> This patch adds protocol support to rule_find, forcing it to
> check protocol match if given by the user.
> 
> Fixes: f9d4b0c1e969 ("fib_rules: move common handling of newrule delrule msgs into fib_nl2rule")
> Signed-off-by: Roopa Prabhu <roopa@...ulusnetworks.com>
> ---

Reviewed-by: David Ahern <dsahern@...il.com>