netdev - Re: [PATCH v3 net-next 7/9] net: ipv4: listified version of ip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <201806300404.VNe69CgA%fengguang.wu@intel.com>
Date:   Sat, 30 Jun 2018 06:44:07 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Edward Cree <ecree@...arflare.com>
Cc:     kbuild-all@...org, davem@...emloft.net, netdev@...r.kernel.org
Subject: Re: [PATCH v3 net-next 7/9] net: ipv4: listified version of ip_rcv

Hi Edward,

I love your patch! Yet something to improve:

[auto build test ERROR on net-next/master]

url:    https://github.com/0day-ci/linux/commits/Edward-Cree/Handle-multiple-received-packets-at-each-stage/20180630-042204
config: x86_64-randconfig-x003-201825 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-16) 7.3.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All errors (new ones prefixed by >>):

   net/ipv4/ip_input.c: In function 'ip_sublist_rcv':
>> net/ipv4/ip_input.c:524:14: error: passing argument 6 of 'NF_HOOK_LIST' from incompatible pointer type [-Werror=incompatible-pointer-types]
           head, dev, NULL, ip_rcv_finish);
                 ^~~
   In file included from include/uapi/linux/netfilter_ipv4.h:9:0,
                    from include/linux/netfilter_ipv4.h:7,
                    from net/ipv4/ip_input.c:145:
   include/linux/netfilter.h:387:1: note: expected 'struct list_head *' but argument is of type 'struct net_device *'
    NF_HOOK_LIST(uint8_t pf, unsigned int hook, struct net *net, struct sock *sk,
    ^~~~~~~~~~~~
   net/ipv4/ip_input.c:524:25: error: passing argument 8 of 'NF_HOOK_LIST' from incompatible pointer type [-Werror=incompatible-pointer-types]
           head, dev, NULL, ip_rcv_finish);
                            ^~~~~~~~~~~~~
   In file included from include/uapi/linux/netfilter_ipv4.h:9:0,
                    from include/linux/netfilter_ipv4.h:7,
                    from net/ipv4/ip_input.c:145:
   include/linux/netfilter.h:387:1: note: expected 'struct net_device *' but argument is of type 'int (*)(struct net *, struct sock *, struct sk_buff *)'
    NF_HOOK_LIST(uint8_t pf, unsigned int hook, struct net *net, struct sock *sk,
    ^~~~~~~~~~~~
>> net/ipv4/ip_input.c:523:2: error: too few arguments to function 'NF_HOOK_LIST'
     NF_HOOK_LIST(NFPROTO_IPV4, NF_INET_PRE_ROUTING, net, NULL,
     ^~~~~~~~~~~~
   In file included from include/uapi/linux/netfilter_ipv4.h:9:0,
                    from include/linux/netfilter_ipv4.h:7,
                    from net/ipv4/ip_input.c:145:
   include/linux/netfilter.h:387:1: note: declared here
    NF_HOOK_LIST(uint8_t pf, unsigned int hook, struct net *net, struct sock *sk,
    ^~~~~~~~~~~~
   cc1: some warnings being treated as errors

vim +/NF_HOOK_LIST +524 net/ipv4/ip_input.c

   517	
   518	static void ip_sublist_rcv(struct list_head *head, struct net_device *dev,
   519				   struct net *net)
   520	{
   521		struct sk_buff *skb, *next;
   522	
 > 523		NF_HOOK_LIST(NFPROTO_IPV4, NF_INET_PRE_ROUTING, net, NULL,
 > 524			     head, dev, NULL, ip_rcv_finish);
   525		list_for_each_entry_safe(skb, next, head, list)
   526			ip_rcv_finish(net, NULL, skb);
   527	}
   528	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (32495 bytes)