netdev - Re: [PATCH v3 net-next 7/9] net: ipv4: listified version of ip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c5599b8a-2576-9c3c-288d-cecf7dd731da@solarflare.com>
Date:   Mon, 2 Jul 2018 15:59:49 +0100
From:   Edward Cree <ecree@...arflare.com>
To:     <netdev@...r.kernel.org>
CC:     kbuild test robot <lkp@...el.com>, <kbuild-all@...org>,
        <davem@...emloft.net>
Subject: Re: [PATCH v3 net-next 7/9] net: ipv4: listified version of ip_rcv

On 29/06/18 23:08, kbuild test robot wrote:
>    net//ipv4/ip_input.c: In function 'ip_sublist_rcv':
>>> net//ipv4/ip_input.c:524:14: warning: passing argument 6 of 'NF_HOOK_LIST' from incompatible pointer type
>            head, dev, NULL, ip_rcv_finish);
>                  ^
>    In file included from include/uapi/linux/netfilter_ipv4.h:9:0,
>                     from include/linux/netfilter_ipv4.h:7,
>                     from net//ipv4/ip_input.c:145:
>    include/linux/netfilter.h:387:1: note: expected 'struct list_head *' but argument is of type 'struct net_device *'
>     NF_HOOK_LIST(uint8_t pf, unsigned int hook, struct net *net, struct sock *sk,
>     ^
>    net//ipv4/ip_input.c:524:25: warning: passing argument 8 of 'NF_HOOK_LIST' from incompatible pointer type
>            head, dev, NULL, ip_rcv_finish);
Looks like I forgot to change my stub for the CONFIG_NETFILTER=n case.
Serves me right for not doing a build test in that configuration.

Updated series to follow shortly.
And thanks, kbuild, for catching it.
-Ed