netdev - Re: [net-next 1/1] tipc: optimize function tipc_node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180630.205223.2203940213481525974.davem@davemloft.net>
Date:   Sat, 30 Jun 2018 20:52:23 +0900 (KST)
From:   David Miller <davem@...emloft.net>
To:     jon.maloy@...csson.com
Cc:     netdev@...r.kernel.org,
        mohan.krishna.ghanta.krishnamurthy@...csson.com,
        tung.q.nguyen@...tech.com.au, hoang.h.le@...tech.com.au,
        canh.d.luu@...tech.com.au, ying.xue@...driver.com,
        tipc-discussion@...ts.sourceforge.net
Subject: Re: [net-next 1/1] tipc: optimize function tipc_node_timeout()

From: Jon Maloy <jon.maloy@...csson.com>
Date: Thu, 28 Jun 2018 22:39:25 +0200

> From: Tung Nguyen <tung.q.nguyen@...tech.com.au>
> 
> In single-link usage, the function tipc_node_timeout() still iterates
> over the whole link array to handle each link. Given that the maximum
> number of bearers are 3, there are 2 redundant iterations with lock
> grab/release. Since this function is executing very frequently it makes
> sense to optimize it.
> 
> This commit adds conditional checking to exit from the loop if the
> known number of configured links has already been accessed.
> 
> Acked-by: Ying Xue <ying.xue@...driver.com>
> Signed-off-by: Tung Nguyen <tung.q.nguyen@...tech.com.au>
> Signed-off-by: Jon Maloy <jon.maloy@...csson.com>

Applied.