netdev - Re: [PATCH net] net/ipv6: Fix updates to prefix route

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180630.205401.1763311729693853504.davem@davemloft.net>
Date:   Sat, 30 Jun 2018 20:54:01 +0900 (KST)
From:   David Miller <davem@...emloft.net>
To:     dsahern@...nel.org
Cc:     netdev@...r.kernel.org, sowmini.varadhan@...cle.com,
        dsahern@...il.com
Subject: Re: [PATCH net] net/ipv6: Fix updates to prefix route

From: dsahern@...nel.org
Date: Thu, 28 Jun 2018 13:36:55 -0700

> From: David Ahern <dsahern@...il.com>
> 
> Sowmini reported that a recent commit broke prefix routes for linklocal
> addresses. The newly added modify_prefix_route is attempting to add a
> new prefix route when the ifp priority does not match the route metric
> however the check needs to account for the default priority. In addition,
> the route add fails because the route already exists, and then the delete
> removes the one that exists. Flip the order to do the delete first.
> 
> Fixes: 8308f3ff1753 ("net/ipv6: Add support for specifying metric of connected routes")
> Reported-by: Sowmini Varadhan <sowmini.varadhan@...cle.com>
> Tested-by: Sowmini Varadhan <sowmini.varadhan@...cle.com>
> Signed-off-by: David Ahern <dsahern@...il.com>

Applied, thanks David.