netdev - Re: [PATCH][net-next] net: increase MAX_GRO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20180702.204428.903903223700362229.davem@davemloft.net>
Date:   Mon, 02 Jul 2018 20:44:28 +0900 (KST)
From:   David Miller <davem@...emloft.net>
To:     lirongqing@...du.com
Cc:     netdev@...r.kernel.org, eric.dumazet@...il.com
Subject: Re: [PATCH][net-next] net: increase MAX_GRO_SKBS to 64

From: Li RongQing <lirongqing@...du.com>
Date: Mon,  2 Jul 2018 19:41:43 +0800

> After 07d78363dcffd [net: Convert NAPI gro list into a small hash table]
> there is 8 hash buckets, which allow more flows to be held for merging.
> 
> keep each as original list length, so increase MAX_GRO_SKBS to 64
> 
> Signed-off-by: Li RongQing <lirongqing@...du.com>

I would like to hear some feedback from Eric, 64 might be too big.