netdev - 答复: [PATCH][net-next] net: increase MAX_GRO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2AD939572F25A448A3AE3CAEA61328C2378160CC@BC-MAIL-M28.internal.baidu.com>
Date:   Mon, 2 Jul 2018 14:09:48 +0000
From:   "Li,Rongqing" <lirongqing@...du.com>
To:     David Miller <davem@...emloft.net>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "eric.dumazet@...il.com" <eric.dumazet@...il.com>
Subject: 答复: [PATCH][net-next] net: increase MAX_GRO_SKBS to 64

________________________________________
发件人: David Miller [davem@...emloft.net]
发送时间: 2018年7月2日 19:44
收件人: Li,Rongqing
抄送: netdev@...r.kernel.org; eric.dumazet@...il.com
主题: Re: [PATCH][net-next] net: increase MAX_GRO_SKBS to 64

From: Li RongQing <lirongqing@...du.com>
Date: Mon,  2 Jul 2018 19:41:43 +0800

>>  After 07d78363dcffd [net: Convert NAPI gro list into a small hash table]
> > there is 8 hash buckets, which allow more flows to be held for merging.
> >
> > keep each as original list length, so increase MAX_GRO_SKBS to 64
> >
> > Signed-off-by: Li RongQing <lirongqing@...du.com>

> I would like to hear some feedback from Eric, 64 might be too big.


I think we should limit each list length to 8 skb , insteading of this change

if there is only one flow,  changing MAX_GRO_SKBS to 64 maybe generate
large delay. 
if keep total 8 skb,  for multiple flow, hash table maybe unable to improve the performance

-RongQing