netdev - Re: [PATCH v5 net-next] net:sched: add action inheritdsfield to skbedit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180704.212800.561269951424444152.davem@davemloft.net>
Date:   Wed, 04 Jul 2018 21:28:00 +0900 (KST)
From:   David Miller <davem@...emloft.net>
To:     qiaobinf@...edu
Cc:     marcelo.leitner@...il.com, dcaratti@...hat.com,
        michel@...irati.com.br, netdev@...r.kernel.org, jhs@...atatu.com,
        xiyou.wangcong@...il.com
Subject: Re: [PATCH v5 net-next] net:sched: add action inheritdsfield to
 skbedit

From: Qiaobin Fu <qiaobinf@...edu>
Date: Sun,  1 Jul 2018 15:16:27 -0400

> The new action inheritdsfield copies the field DS of
> IPv4 and IPv6 packets into skb->priority. This enables
> later classification of packets based on the DS field.
> 
> v5:
> *Update the drop counter for TC_ACT_SHOT
> 
> v4:
> *Not allow setting flags other than the expected ones.
> 
> *Allow dumping the pure flags.
> 
> v3:
> *Use optional flags, so that it won't break old versions of tc.
> 
> *Allow users to set both SKBEDIT_F_PRIORITY and SKBEDIT_F_INHERITDSFIELD flags.
> 
> v2:
> *Fix the style issue
> 
> *Move the code from skbmod to skbedit
> 
> Original idea by Jamal Hadi Salim <jhs@...atatu.com>
> 
> Signed-off-by: Qiaobin Fu <qiaobinf@...edu>
> Reviewed-by: Michel Machado <michel@...irati.com.br>
> Acked-by: Jamal Hadi Salim <jhs@...atatu.com>
> Reviewed-by: Marcelo Ricardo Leitner <marcelo.leitner@...il.com>
> Acked-by: Davide Caratti <dcaratti@...hat.com>

Applied.