lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 04 Jul 2018 14:01:28 +0900 (KST) From: David Miller <davem@...emloft.net> To: roy.qing.li@...il.com Cc: lirongqing@...du.com, netdev@...r.kernel.org, eric.dumazet@...il.com Subject: Re: [PATCH][net-next] net: increase MAX_GRO_SKBS to 64 From: Li RongQing <roy.qing.li@...il.com> Date: Tue, 3 Jul 2018 14:21:48 +0800 > On 7/2/18, David Miller <davem@...emloft.net> wrote: >> From: Li RongQing <lirongqing@...du.com> >> Date: Mon, 2 Jul 2018 19:41:43 +0800 >> >>> After 07d78363dcffd [net: Convert NAPI gro list into a small hash table] >>> there is 8 hash buckets, which allow more flows to be held for merging. >>> >>> keep each as original list length, so increase MAX_GRO_SKBS to 64 >>> >>> Signed-off-by: Li RongQing <lirongqing@...du.com> >> >> I would like to hear some feedback from Eric, 64 might be too big. >> > How about the below change? > > commit 6270b973a973b2944fedb4b5f9926ed3e379d0c2 (HEAD -> master) > Author: Li RongQing <lirongqing@...du.com> > Date: Mon Jul 2 19:08:37 2018 +0800 > > net: limit each hash list length to MAX_GRO_SKBS Yes, this is much better. > @@ -324,6 +324,7 @@ struct napi_struct { > #endif > struct net_device *dev; > struct list_head gro_hash[GRO_HASH_BUCKETS]; > + int list_len[GRO_HASH_BUCKETS]; For cache locality, it is probably best to make gro_hash an array of structures whose members are: struct list_head hash_chain; int list_len;
Powered by blists - more mailing lists