netdev - Re: [PATCH 2/3 v2] net: phy: vitesse: Add support for VSC73xx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20180704.113230.1134845998887388983.davem@davemloft.net>
Date:   Wed, 04 Jul 2018 11:32:30 +0900 (KST)
From:   David Miller <davem@...emloft.net>
To:     linus.walleij@...aro.org
Cc:     andrew@...n.ch, vivien.didelot@...oirfairelinux.com,
        f.fainelli@...il.com, netdev@...r.kernel.org,
        openwrt-devel@...ts.openwrt.org, lede-dev@...ts.infradead.org,
        juhosg@...nwrt.org
Subject: Re: [PATCH 2/3 v2] net: phy: vitesse: Add support for VSC73xx

From: Linus Walleij <linus.walleij@...aro.org>
Date: Sat, 30 Jun 2018 13:17:30 +0200

> The VSC7385, VSC7388, VSC7395 and VSC7398 are integrated
> switch/router chips for 5+1 or 8-port switches/routers. When
> managed directly by Linux using DSA we need to do a special
> set-up "dance" on the PHY. Unfortunately these sequences
> switches the PHY to undocumented pages named 2a30 and 52b6
> and does undocumented things. It is described by these opaque
> sequences also in the reference manual. This is a best
> effort to integrate it anyways.
> 
> Reviewed-by: Florian Fainelli <f.fainelli@...il.com>
> Signed-off-by: Linus Walleij <linus.walleij@...aro.org>
> ---
> ChangeLog v1->v2:
> - Drop <linux/delay.h> from an earlier iteration.
> - Implement an .config_aneg() routine that does nothing: the
>   imroved genphy_config_aneg() makes the device fail as of
>   v4.18-rc1 and the device seems to feel best like this: it
>   comes up in autonegotiation mode and we do not try to instruct
>   it.
> - Use some MII defines when reading/writing registers.
> - Collect Florian's ACK.

Applied.