netdev - Re: [PATCH net-next] tcp: remove SG-related comment in tcp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5057f0d2-1d48-1665-8f9b-6123f7d3302c@gmail.com>
Date:   Fri, 6 Jul 2018 03:08:07 -0700
From:   Eric Dumazet <eric.dumazet@...il.com>
To:     Julian Wiedmann <jwi@...ux.ibm.com>,
        David Miller <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH net-next] tcp: remove SG-related comment in tcp_sendmsg()



On 07/06/2018 12:19 AM, Julian Wiedmann wrote:
> Since commit 74d4a8f8d378 ("tcp: remove sk_can_gso() use"), the code
> doesn't care whether the interface supports SG.
> 
> Signed-off-by: Julian Wiedmann <jwi@...ux.ibm.com>
> ---
>  net/ipv4/tcp.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/net/ipv4/tcp.c b/net/ipv4/tcp.c
> index bf461fa77ed6..516e89b57603 100644
> --- a/net/ipv4/tcp.c
> +++ b/net/ipv4/tcp.c
> @@ -1275,9 +1275,7 @@ int tcp_sendmsg_locked(struct sock *sk, struct msghdr *msg, size_t size)
>  			int linear;
>  
>  new_segment:
> -			/* Allocate new segment. If the interface is SG,
> -			 * allocate skb fitting to single page.
> -			 */
> +			/* Allocate new segment. */

Hi Julian

Please remove the comment completely then, it is really just redundant after this label.

Thanks.