netdev - [PATCH net-next v2] tcp: remove SG-related comment in tcp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon,  9 Jul 2018 09:45:14 +0200
From:   Julian Wiedmann <jwi@...ux.ibm.com>
To:     David Miller <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>
Cc:     Julian Wiedmann <jwi@...ux.ibm.com>, <netdev@...r.kernel.org>
Subject: [PATCH net-next v2] tcp: remove SG-related comment in tcp_sendmsg()

Since commit 74d4a8f8d378 ("tcp: remove sk_can_gso() use"), the code
doesn't care whether the interface supports SG.

Signed-off-by: Julian Wiedmann <jwi@...ux.ibm.com>
---
v2: remove the whole comment (Eric)

 net/ipv4/tcp.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/net/ipv4/tcp.c b/net/ipv4/tcp.c
index bf461fa77ed6..6ce14f8e3562 100644
--- a/net/ipv4/tcp.c
+++ b/net/ipv4/tcp.c
@@ -1275,9 +1275,6 @@ int tcp_sendmsg_locked(struct sock *sk, struct msghdr *msg, size_t size)
 			int linear;
 
 new_segment:
-			/* Allocate new segment. If the interface is SG,
-			 * allocate skb fitting to single page.
-			 */
 			if (!sk_stream_memory_free(sk))
 				goto wait_for_sndbuf;
 
-- 
2.16.4