netdev - Re: [PATCH net-next v2 09/10] r8169: remove mii_if_info member from struct rtl8169

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180710210036.GK892@lunn.ch>
Date:   Tue, 10 Jul 2018 23:00:36 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Heiner Kallweit <hkallweit1@...il.com>
Cc:     David Miller <davem@...emloft.net>,
        Florian Fainelli <f.fainelli@...il.com>,
        Realtek linux nic maintainers <nic_swsd@...ltek.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next v2 09/10] r8169: remove mii_if_info member from
 struct rtl8169_private

> @@ -6719,7 +6703,7 @@ static int r8169_phy_connect(struct rtl8169_private *tp)
>  	if (ret)
>  		return ret;
>  
> -	if (!tp->mii.supports_gmii && phydev->supported & PHY_1000BT_FEATURES) {
> +	if (!tp->supports_gmii && phydev->supported & PHY_1000BT_FEATURES) {

It is better to use phy_set_max_speed() with SPEED_100 if
tp->supports_gmii is not set.

	  Andrew