netdev - Re: [PATCH net-next v2 09/10] r8169: remove mii_if_info member from struct rtl8169

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180710213726.GA29156@lunn.ch>
Date:   Tue, 10 Jul 2018 23:37:26 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Heiner Kallweit <hkallweit1@...il.com>
Cc:     David Miller <davem@...emloft.net>,
        Florian Fainelli <f.fainelli@...il.com>,
        Realtek linux nic maintainers <nic_swsd@...ltek.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next v2 09/10] r8169: remove mii_if_info member from
 struct rtl8169_private

On Tue, Jul 10, 2018 at 11:32:36PM +0200, Heiner Kallweit wrote:
> On 10.07.2018 23:00, Andrew Lunn wrote:
> >> @@ -6719,7 +6703,7 @@ static int r8169_phy_connect(struct rtl8169_private *tp)
> >>  	if (ret)
> >>  		return ret;
> >>  
> >> -	if (!tp->mii.supports_gmii && phydev->supported & PHY_1000BT_FEATURES) {
> >> +	if (!tp->supports_gmii && phydev->supported & PHY_1000BT_FEATURES) {
> > 
> > It is better to use phy_set_max_speed() with SPEED_100 if
> > tp->supports_gmii is not set.
> > 
> Then the info message wouldn't fit any longer, it's meaningful in case
> 1GBit PHY + 100MBit MAC only.

What you should avoid is this part:

phydev->supported & PHY_1000BT_FEATURES

Because phydev->supported is going to go away sometime soon. 

Does anybody care about knowing they have a 1Gbit PHY connected to the
100Mbit MAC? So long as it works, i think not.

	Andrew